Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing item from the list sometimes leaves materials in it #40

Closed
Supamiu opened this issue Sep 25, 2017 · 1 comment
Closed

removing item from the list sometimes leaves materials in it #40

Supamiu opened this issue Sep 25, 2017 · 1 comment
Assignees
@Supamiu
Labels
bug
Milestone
1.3.0

Comments

@Supamiu
Copy link
Member

Supamiu commented Sep 25, 2017

When removing an item from the list, materials are sometimes remaining.

Steps to reproduce:

  • Create a List
  • Add Persimmon Leaf Sushi in it
  • Change the amount for a high one (50+)
  • Add another item to the recipe
  • Remove Persimmon Leaf Sushi
  • Some fishes will still be in the materials required
@Supamiu Supamiu added the bug label Sep 25, 2017
@Supamiu Supamiu added this to the 1.3.0 milestone Sep 25, 2017
@Supamiu Supamiu self-assigned this Sep 25, 2017
@Supamiu
Copy link
Member Author

Supamiu commented Sep 25, 2017

It seems like this is an issue related to recipes that yield more than one item, probably a rounding issue.

@Supamiu Supamiu mentioned this issue Sep 25, 2017
Closed
Supamiu added a commit that referenced this issue Sep 25, 2017
@Supamiu
fix: recipe amount sometimes wrong with high amount of items
89b73f5 
Closes #40

We need to refactor the maths to change for a full integer implementation, we will avoid float issues this way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Supamiu Supamiu

Labels
bug
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@Supamiu