-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exactly sitting on a tag fails #4
Comments
Thank you for looking into the issue and thank you for the PR. I am a bit thorn between the proposed fix and fixing the parsing. I'd probably like the tarball and github tag to generate the same version. |
Feel free to fix as you see fit. I’m rather assuming here that the git hash and revision count are removed later if the count is 0 (that might depend on how you handle dirty working trees). |
As pointed out in #5 (comment), I will pull |
Okay, let me know when there's a fix. :) |
This line breaks when this matches a tag exactly (which it usually should do if you are building wheels and SDists for publication?)
trampolim/trampolim/_build.py
Line 290 in f3e8db8
You want
--long
to force the commits since tag and current hash. Or you should check to see if-
's are present, then assume it's exactly a release then.Example failure from a nox run using scikit-hep/cookie:
This works correctly in setuptools_scm.
The text was updated successfully, but these errors were encountered: