Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/create favorite controller #287

Closed
wants to merge 4 commits into from

Conversation

Ridersk
Copy link
Contributor

@Ridersk Ridersk commented Nov 9, 2018

Fixes #

Alterações realizadas

  • Criação dos favoritos utilizando nas requests o identifier do usuário obtido no front e realizado verificação antes se esse usuário já está cadastrado no back ao invés da request json utilizar o id do usuário no rails diretamente.
  • Listagem de favoritos também utilizando o identifier do usuário do front.

@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 664

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 98.708%

Files with Coverage Reduction New Missed Lines %
app/controllers/user_identifiers_controller.rb 1 93.33%
app/controllers/favorite_locals_controller.rb 1 96.43%
Totals Coverage Status
Change from base Build 648: -0.1%
Covered Lines: 764
Relevant Lines: 774

💛 - Coveralls

@zarbielli zarbielli self-requested a review November 10, 2018 12:28
Co-authored-by: zarbielli <jlfz06@gmail.com>
@Ridersk Ridersk closed this Nov 13, 2018
@Ridersk
Copy link
Contributor Author

Ridersk commented Nov 13, 2018

Pull Request movido para #290 com o link para a issue #64

@min-ia min-ia deleted the refactor/create-favorite-controller branch November 17, 2018 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants