Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#189 atualizar avaliacoes #195

Merged
merged 6 commits into from
May 10, 2021
Merged

Conversation

oEduardoAfonso
Copy link
Collaborator

Descrição

Alterada estrutura da avaliação, alterados testes e validações.

Resolve (Issues)

#189

Como Isso Foi Testado (caso necessário)?

Utilizando a ferramenta Docker, a extensão do VS Code Thunder Client e a branch do front end.

Capturas de Tela (se apropriado):

image

Tarefas gerais realizadas

  • Criados campos dos novos critérios
  • Campo rating virou a media dos critérios avaliativos
  • Adaptados teste
  • Limite máximo das notas alterado para 5

app/model/post.py Outdated Show resolved Hide resolved
@thiagohdaqw thiagohdaqw changed the title Feature/#189 atualizar avaliacoes #189 atualizar avaliacoes May 5, 2021
app/schemas/post_schema.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@thiagohdaqw thiagohdaqw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boaa. Bom trabalho

@thiagohdaqw thiagohdaqw force-pushed the feature/#189-Atualizar_Avaliacoes branch from a944e33 to 8b458e5 Compare May 6, 2021 03:04
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@3d1d3eb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #195   +/-   ##
==========================================
  Coverage           ?   99.59%           
==========================================
  Files              ?       36           
  Lines              ?      734           
  Branches           ?        0           
==========================================
  Hits               ?      731           
  Misses             ?        3           
  Partials           ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1d3eb...8b458e5. Read the comment docs.

Copy link
Collaborator

@Balbinoo Balbinoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fiz docker down e build, testei com o front e deu tudo certo, bom trabalho!

Copy link
Collaborator

@RcleydsonR RcleydsonR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ae Dudu, tudo certo com o PR ! Excelente trabalho, mas vamos esperar pra dar o merge nele junto com o front-end por conta dos dados alterados nos posts.

@RcleydsonR RcleydsonR merged commit 3010c75 into develop May 10, 2021
@thiagohdaqw thiagohdaqw deleted the feature/#189-Atualizar_Avaliacoes branch May 13, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants