Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For user specific thing-at-point add a new property 'highlight-thing-… #18

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

antoineB
Copy link

…rx-fn

taking a function that construct a specific regexp instead of the default.

…rx-fn

taking a function that construct a specific regexp instead of the default.
@fgeller
Copy link
Owner

fgeller commented Dec 21, 2018

thanks @antoineB ! i guess that the ultimate form of customizing it 👍

i'll merge your work and then apply some changes - just started typing up the suggestions and realized it's quicker to just code them.

@fgeller fgeller merged commit 5f1d19c into fgeller:master Dec 21, 2018
@fgeller
Copy link
Owner

fgeller commented Dec 21, 2018

@antoineB so just renamed the property to highlight-thing-regex-fn for a bit more consistency with the other names, you probably need to update your call to put the property if you change to the updated version.
I'd like to add a note to the readme for this, would you mind sharing your use case rather that me making something up?

fgeller added a commit that referenced this pull request Dec 21, 2018
fgeller added a commit that referenced this pull request Dec 21, 2018
@antoineB
Copy link
Author

I wanted to highlight variables in a php buffer. Php variable are of the form "$[a-zA-Z_0-9]+" but the 'symbol thing-at-point does only match the "[a-zA-Z_0-9]+" part so I make a 'php-var-symbol thingy. It turns out the highlight-thing.el has a special case for 'symbol that put word boundary on the regexp it search for so I made this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants