Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature for search closest path #7

Open
wants to merge 5 commits into
base: wip
Choose a base branch
from
Open

Conversation

Tarzeron
Copy link

Fixes #3

Copy link
Owner

@fgenesis fgenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • closestBestDistance should be ScoreType.
  • M_MAX_UNSIGNED is not a standard symbol, might want to use unsigned(-1) or UINT_MAX instead. But since ScoreType can also be float, there should be a MAX_DISTANCE constant depending on the type.

If you want to do changes go ahead, otherwise i'll merge this in a bit and fix it up in the process. Whatever you prefer. And thanks for this!

@Tarzeron
Copy link
Author

hi i have corrected your requirements and added some more optimizations

@luodaoyi
Copy link

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants