Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selection problem. #14

Closed
gbmgbm opened this issue Apr 26, 2019 · 8 comments
Closed

Language selection problem. #14

gbmgbm opened this issue Apr 26, 2019 · 8 comments

Comments

@gbmgbm
Copy link

gbmgbm commented Apr 26, 2019

It only detects the channel language.
It can't detect broadcaster language.

I think broadcaster language should be given priority over channel language.

Thank you.

@auto-comment
Copy link

auto-comment bot commented Apr 26, 2019

Thank your for raising a issue. I will try and get back to you as soon as possible.
Regards @fgl27

@fgl27
Copy link
Owner

fgl27 commented Apr 26, 2019

That is how twitch sends the content the app just display it.

I can't change it, tell the streamer that they aren't align.

@fgl27 fgl27 closed this as completed Apr 26, 2019
@fgl27
Copy link
Owner

fgl27 commented Apr 27, 2019

that is how is requested

https://dev.twitch.tv/docs/v5/reference/streams/#get-live-streams
"Constrains the language of the streams returned. Valid value: a locale ID string; for example, en, fi, es-mx. Only one language can be specified. Default: all languages."

The app can only shows what it receives from the api, no filter is done to add or remove content locally in the app because that is too much slow to do locally that is way a api is needed and twitch one is not perfect.

fgl27 added a commit that referenced this issue Apr 29, 2019
Make the content to show more close to the website

adress issue #14

Signed-off-by: Felipe Leon <fglfgl27@gmail.com>
@fgl27
Copy link
Owner

fgl27 commented Apr 29, 2019

@gbmgbm I discover that one can request language by broadcast language, but that is a undocumented option that I manage to find by guessing. so the above change the live content that uses language to show "broadcaster_language".

Only works to show content only on Live and Agame screen as those are the only "live" content that accepts the filter.

Other changes there are related to the display of the language in the information panel and thumbnails

@Cabeza2000
Copy link

Cabeza2000 commented Apr 29, 2019

Hey Felipe, thanks for this app. Just installed and is working fine (still did not turn off the TV but hopefully will not have the bug described in issues 11 and 18).

About language selection I just have a problem, in the discontinued app I used to filter by more than one language (Spanish and English) but could not find a way to do it in your app? Is this something that you can add in the future?

@fgl27
Copy link
Owner

fgl27 commented Apr 29, 2019

@Cabeza2000 yes of course, open a issue with a featuring request so I don't forget about it

@Cabeza2000
Copy link

Done. Thanks!

#20

@gbmgbm
Copy link
Author

gbmgbm commented May 2, 2019

@fgl27 Many thanks. Everything is working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants