Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off cc (Closed Captions) #243

Closed
TedCassirer opened this issue Aug 15, 2022 · 6 comments
Closed

Option to turn off cc (Closed Captions) #243

TedCassirer opened this issue Aug 15, 2022 · 6 comments
Assignees
Labels
bug Something isn't working need a fix Tizen and or device issue Tizen has a lot of issue this is a issue that when tested on different devices/OS will not happen

Comments

@TedCassirer
Copy link

Certain streams feature closed captions. This app enabled this by default with no way to turn them off. The text is displayed over the stream making it very annoying to watch. There is an api to turn it off found here https://dev.twitch.tv/docs/embed/video-and-clips#synchronous-javascript-playback-api

Here's a streamer that have CC turned on https://www.twitch.tv/tgh_sr

@fgl27
Copy link
Owner

fgl27 commented Aug 15, 2022

this app doesn't uses twitch player api from the link https://dev.twitch.tv/docs/embed/video-and-clips#synchronous-javascript-playback-api

this is the player api used https://developer.samsung.com/smarttv/develop/api-references/samsung-product-api-references/avplay-api.html#AVPlayManager-setExternalSubtitlePath

the app doesn't enable anything related to cc, so I don't know how it is been displayed for you.

can you see it on VODs?

Show me how they look on yours TV running this app.

@TedCassirer
Copy link
Author

They show up in VODs.
20220815_143250

Screenshot is from this vod and time
If the text doesn't show up for you when you open it up in your browser you might need to click the [CC] button in the bottom right corner. I've noticed that it sometimes takes a couple of seconds for it to appear.

fgl27 added a commit that referenced this issue Aug 15, 2022
@fgl27
Copy link
Owner

fgl27 commented Aug 15, 2022

I push the above to the app, that is the only reference on anything related to subtitle or CC on the API.

Test and let me know the result, to test just force close the app by holding return key when it open again will be updated with that change.

@TedCassirer
Copy link
Author

That worked! Good stuff. I did not expect it to because I made sure all the subtitles settings were turned off on my TV before I created this issue.

Feel free to close this ticket unless you want to keep this issue around if you plan on adding this as a toggleable option

@fgl27
Copy link
Owner

fgl27 commented Aug 16, 2022

Thank you.

For now I will just close as turning this in to a feature isn't simple.

The player API support differs from TV to TV, I can't know for sure with TV support or with stream have CC, with makes very difficult to properly add a enable/disable option.

If that changes on the future I'll add a proper feature.

@fgl27 fgl27 closed this as completed Aug 16, 2022
@fgl27 fgl27 added bug Something isn't working need a fix Tizen and or device issue Tizen has a lot of issue this is a issue that when tested on different devices/OS will not happen labels Aug 16, 2022
@fgl27 fgl27 self-assigned this Aug 16, 2022
@k3vink3vin
Copy link

Seeing closed captions in gibberish on the official twitch con stream.

PXL_20221007_223139044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need a fix Tizen and or device issue Tizen has a lot of issue this is a issue that when tested on different devices/OS will not happen
Projects
None yet
Development

No branches or pull requests

3 participants