-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to turn off cc (Closed Captions) #243
Comments
this app doesn't uses twitch player api from the link https://dev.twitch.tv/docs/embed/video-and-clips#synchronous-javascript-playback-api this is the player api used https://developer.samsung.com/smarttv/develop/api-references/samsung-product-api-references/avplay-api.html#AVPlayManager-setExternalSubtitlePath the app doesn't enable anything related to cc, so I don't know how it is been displayed for you. can you see it on VODs? Show me how they look on yours TV running this app. |
Screenshot is from this vod and time |
I push the above to the app, that is the only reference on anything related to subtitle or CC on the API. Test and let me know the result, to test just force close the app by holding return key when it open again will be updated with that change. |
That worked! Good stuff. I did not expect it to because I made sure all the subtitles settings were turned off on my TV before I created this issue. Feel free to close this ticket unless you want to keep this issue around if you plan on adding this as a toggleable option |
Thank you. For now I will just close as turning this in to a feature isn't simple. The player API support differs from TV to TV, I can't know for sure with TV support or with stream have CC, with makes very difficult to properly add a enable/disable option. If that changes on the future I'll add a proper feature. |
Certain streams feature closed captions. This app enabled this by default with no way to turn them off. The text is displayed over the stream making it very annoying to watch. There is an api to turn it off found here https://dev.twitch.tv/docs/embed/video-and-clips#synchronous-javascript-playback-api
Here's a streamer that have CC turned on https://www.twitch.tv/tgh_sr
The text was updated successfully, but these errors were encountered: