Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support abstract SM classes. Closes #350 #353

Merged
merged 1 commit into from Feb 22, 2023

Conversation

fgmacedo
Copy link
Owner

@fgmacedo fgmacedo commented Feb 22, 2023

Closes #350

StateMachine now can now be subclassed with abstract classes (ones that do not define states or transitions). Abstract StateMachines cannot be instantiated.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (5ba3e50) compared to base (0a54b24).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          862       866    +4     
  Branches       140       141    +1     
=========================================
+ Hits           862       866    +4     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
statemachine/factory.py 100.00% <100.00%> (ø)
statemachine/statemachine.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fgmacedo fgmacedo marked this pull request as ready for review February 22, 2023 18:25
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fgmacedo fgmacedo added this to the 2.0.0 milestone Feb 22, 2023
@fgmacedo fgmacedo merged commit a74defb into develop Feb 22, 2023
@fgmacedo fgmacedo deleted the macedo/abstract-classes branch February 22, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting abstract classes
1 participant