Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improved factory type hints #399

Merged
merged 1 commit into from Aug 3, 2023

Conversation

fgmacedo
Copy link
Owner

@fgmacedo fgmacedo commented Aug 2, 2023

Improve type hints as pointed out on #398.

Closes #398.

@ghost
Copy link

ghost commented Aug 2, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d16ee12) 100.00% compared to head (cbef007) 100.00%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          991       995    +4     
  Branches       165       165           
=========================================
+ Hits           991       995    +4     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
statemachine/factory.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgmacedo fgmacedo force-pushed the macedo/improve-metaclass-typehint branch from 259ab56 to cbef007 Compare August 2, 2023 17:36
@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fgmacedo fgmacedo marked this pull request as ready for review August 2, 2023 17:37
@fgmacedo fgmacedo merged commit 0469cb0 into develop Aug 3, 2023
14 checks passed
@fgmacedo fgmacedo deleted the macedo/improve-metaclass-typehint branch August 3, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotations missing for initial_state and final_states; leading to linting errors with Pylint/Pyright
1 participant