Reconstructing callable references when using deepcopy over a SM. #425
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424.
Issue
As declared on the related issue:
The root cause of the issue lies in the
setUpTestData()
method. Every cls attr created in this method is wrapped in a TestData class, which performs adeepcopy()
for each test, so this is designed to allow safe alteration of objects between tests on the sameTestCase
instance.However, this conflicts with the creation strategy of state machines. The references of properties/methods used as actions/conditions are computed at the time of creation. So, when the state machine is cloned, the references still point to the original instance.
Fix
We've added a hook on the
deepcopy
Python protocol, where we reconstruct the new instance callable references.Tests