Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improved setup time by 40% #433

Merged
merged 1 commit into from May 6, 2024

Conversation

fgmacedo
Copy link
Owner

@fgmacedo fgmacedo commented May 6, 2024

Improved setup time by 40% changing state and transitions callbacks setup to the class factory (run only once per class instead of by instance creation.

Name (time in us)                              Min                 Max                Mean             StdDev              Median                IQR
-------------------------------------------------------------------------------------------------------------------------------------------------------------
test_setup_performance (NOW)              304.8569 (1.0)      342.2025 (1.0)      318.1129 (1.0)      13.6022 (1.0)      311.9030 (1.0)      25.0701 (1.0)
test_setup_performance (0139_df06976)     421.6639 (1.38)     508.5238 (1.49)     444.7448 (1.40)     25.9961 (1.91)     436.4050 (1.40)     25.7991 (1.03)
-------------------------------------------------------------------------------------------------------------------------------------------------------------

image

Note: The Graph diagram on class now includes all default callbacks hooks, because the class now knows the expected hooks names, even if there's no callback handler on the statemachine class.

… setup to factory (run only once per class instead of by instance creation
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (df06976) to head (21186cc).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #433   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         1196      1200    +4     
  Branches       174       174           
=========================================
+ Hits          1196      1200    +4     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fgmacedo fgmacedo merged commit 4f334c3 into develop May 6, 2024
13 checks passed
@fgmacedo fgmacedo deleted the macedo/improved-setup-at-class-factory branch May 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant