Prevent TypeError due to undefined property when parsing styles

fgnass · Jan 26, 2016 · ec3e338 · ec3e338
1 parent a792135
commit ec3e338
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/CSSStyleDeclaration.js b/lib/CSSStyleDeclaration.js
@@ -13,7 +13,7 @@ function CSSStyleDeclaration(elt) {
 // {"margin-left":"5px", "border-style":"solid"}
 function parseStyles(s) {
   var parser = new parserlib.css.Parser();
-  var result = {};
+  var result = { important: {} };
   parser.addListener("property", function(e) {
     if (e.invalid) return; // Skip errors
     result[e.property.text] = e.value.text;

diff --git a/test/domino.js b/test/domino.js
@@ -540,3 +540,11 @@ exports.contains = function() {
   nodeList[0].contains(nodeList[1]).should.equal(false);
   nodeList[1].contains(nodeList[0]).should.equal(false);
 };
+
+exports.parseImportant = function() {
+  var html = '<p style="font-family:sans-serif; text-decoration:none !important">foo</p>';
+  var doc = domino.createDocument(html);
+  var p = doc.querySelector('p');
+  p.style.fontFamily.should.equal('sans-serif');
+  p.style.textDecoration.should.equal('none');
+};