Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node.ELEMENT_NODE (&etc) should be properties of Node.prototype. #14

Closed
cscott opened this issue Feb 16, 2013 · 1 comment
Closed

Node.ELEMENT_NODE (&etc) should be properties of Node.prototype. #14

cscott opened this issue Feb 16, 2013 · 1 comment

Comments

@cscott
Copy link
Collaborator

cscott commented Feb 16, 2013

Typing "document.ELEMENT_NODE" into the webkit JavaScript console confirms that the node type properties are inherited from Node. But Node.js adds the properties to Node, not Node.prototype, so they are not inherited by Document (or any of the other subclasses).

Node.prototype should get a copy of the node type properties, as well as Node.
cscott added a commit to cscott/domino that referenced this issue Feb 16, 2013
@cscott
Mirror Node type properties into Node.prototype. (github fgnass#14)
a855737 
Webkit defines document.ELEMENT_NODE, but domino previously defined
only Node.ELEMENT_NODE.  This patch adds the node types to Node.prototype
so that they are inherited by instances of Node and its subclasses.
fgnass added a commit that referenced this issue Feb 16, 2013
@fgnass
Merge pull request #15 from cscott/gh-14
67f5ad0 
Mirror Node type properties into Node.prototype.  (github #14)
@cscott
Copy link
Collaborator Author

cscott commented Feb 17, 2013

Patch pulled, this issue can be closed.

@cscott cscott closed this as completed Feb 17, 2013
@cscott cscott mentioned this issue May 2, 2013
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cscott