Fix Document.title to match DOM spec (create <title> if missing). #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscott
added a commit
that referenced
this pull request
Apr 9, 2013
Fix Document.title to match DOM spec (create <title> if missing).
wmfgerrit
pushed a commit
to wikimedia/mediawiki-services-parsoid
that referenced
this pull request
Jul 16, 2014
* Removes the hotfix file for domino. Was only being used in some
places (a potential source of errors) and considering cscott lives
upstream, it shouldn't be a problem getting fixes merged. Also, we
seem to be using the "fork and put a link to a git repo in the
package.json" pattern in other cases.
* The bug being worked around in the PostProcessor was fixed by:
fgnass/domino#29
* Some other minor cleanup.
Change-Id: I0968e1eeca05e07f1ddd736a99acd7a88c5e610d
cscott
added a commit
that referenced
this pull request
Feb 14, 2018
We can't make direct array access (`node.attributes[n]`) work without Proxy support (see gh #29) but by defining a custom iterator we can make `Array.from` and for-of loops work on `node.attributes`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
domino would do a no-op for "document.title = ...." if there wasn't already a <title> element in the document's . Fix the behavior to match the DOM spec (http://www.whatwg.org/specs/web-apps/current-work/#the-title-element-0).