Fixes bug in formatting element adoption agency algorithm #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As per the whatwg specs [1], further processing of formatting elements has to stop if no "furthest block" is found on top of the formatting elements. * This fixes bug in parsing the following snippet: "<em>foo<em>bar</em>baz</em>" which would get parsed as: "<em>foo<em>bar</em></em>baz" Reported as a bug in Parsoid [2] * All existing tests pass -- new tests required. [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#adoption-agency-algorithm [2] https://bugzilla.wikimedia.org/show_bug.cgi?id=50604
|
It would be good to add the new test case cited in the commit message. I'll try to do that today, then merge. |
|
Added a new test. Not sure if the pull request will include that or not. If not, I can issue a new pull request. |
cscott
added a commit
that referenced
this pull request
Jul 8, 2013
Fixes bug in formatting element adoption agency algorithm
cscott
added a commit
that referenced
this pull request
Jul 8, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the whatwg specs [1], further processing of formatting
elements has to stop if no "furthest block" is found on top of
the formatting elements.
This fixes bug in parsing the following snippet:
"foobarbaz" which would get parsed as:
"foobarbaz"
Reported as a bug in Parsoid [2]
All existing tests pass -- new tests required.
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#adoption-agency-algorithm
[2] https://bugzilla.wikimedia.org/show_bug.cgi?id=50604