Skip to content

Commit

Permalink
Update eslint infra
Browse files Browse the repository at this point in the history
  • Loading branch information
Tomek Wiszniewski committed May 28, 2016
1 parent e93f851 commit 6fa106f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .eslintrc
View file
@@ -1,6 +1,6 @@
{
"extends": [
"airbnb/legacy"
"airbnb-base/legacy"
],
"rules": {
"comma-dangle": [2, "never"],
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Expand Up @@ -40,7 +40,8 @@
"devDependencies": {
"coffee-script": "^1.8.0",
"eslint": "^2.0.0",
"eslint-config-airbnb": "^8.0.0",
"eslint-config-airbnb-base": "^3.0.1",
"eslint-plugin-import": "^1.8.1",
"tap": "^5.2.0",
"touch": "^1.0.0"
}
Expand Down

1 comment on commit 6fa106f

@tomek-he-him
Copy link
Collaborator

@tomek-he-him tomek-he-him commented on 6fa106f May 28, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fgnass By the way, I noticed some unmet peer dependencies of eslint-config-airbnb. They updated their package structure recently and there were a couple of breaking changes in the meantime. eslint-config-airbnb-base/legacy seems to be the way to go now. I updated it to use that.

However, eslint shows a couple of errors – the same number both before and after the update:

$ ./node_modules/.bin/eslint .

lib/hook.js
  26:7  error  Expected { after 'if' condition        curly
  26:7  error  Expected space(s) after "if"           keyword-spacing
  37:5  error  Using 'ForInStatement' is not allowed  no-restricted-syntax

lib/index.js
  24:13  error  Unexpected require()  global-require
  25:13  error  Unexpected require()  global-require
  26:16  error  Unexpected require()  global-require

lib/wrap.js
  21:3   error  Unexpected require()  global-require
  63:12  error  Unexpected require()  global-require
  69:3   error  Unexpected require()  global-require

test/fixture/catchNoSuchModule.js
  2:3   error  Unexpected require()                                                global-require
  2:11  error  Unable to resolve path to module 'some_module_that_does_not_exits'  import/no-unresolved

test/fixture/cluster.js
  18:3  error  Unexpected require()  global-require

test/fixture/noSuchModule.js
  1:9  error  Unable to resolve path to module 'some_module_that_does_not_exits'  import/no-unresolved

test/fixture/vmtest.js
  6:1  error  Expected space(s) after "if"  keyword-spacing

test/index.js
    9:5   error  'ignoredFile' is defined but never used                           no-unused-vars
   13:5   error  'MESSAGE' is defined but never used                               no-unused-vars
   18:23  error  Unnecessary use of conditional expression for default assignment  no-unneeded-ternary
   60:14  error  Expected to return a value at the end of this function            consistent-return
   63:14  error  Expected to return a value at the end of this function            consistent-return
   86:22  error  Expected to return a value at the end of this function            consistent-return
   89:14  error  Expected to return a value at the end of this function            consistent-return
   92:18  error  Expected to return a value at the end of this function            consistent-return
  161:21  error  Expected to return a value at the end of this function            consistent-return
  164:14  error  Expected to return a value at the end of this function            consistent-return
  181:40  error  Expected to return a value at the end of this function            consistent-return
  183:14  error  Expected to return a value at the end of this function            consistent-return
  255:22  error  Expected to return a value at the end of this function            consistent-return
  258:14  error  Expected to return a value at the end of this function            consistent-return

✖ 28 problems (28 errors, 0 warnings)

Just saying. 😄 Sorry, I didn’t have the time to pull these things straight. I’m also not sure you agree with eslint there.

Please sign in to comment.