Correction in README about extraneous command-line arguments #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a statement in the README about command-line arguments that are not node-dev options "are passed on to the node process." In practice this is not the case and passing Node arguments such as `--preserve-symlinks` results in the process exiting with an AssertionError (see screenshot below). ### Screenshot <img width="1512" alt="image" src="https://user-images.githubusercontent.com/369384/156674030-a3c50dc0-1c86-48b3-a08f-d6125d6c20a4.png">
|
Otherwise it looks like you're trying to run We have added the most requested options for node which has very non-standard command line parsing that we aren't trying to fully replicate. I'd be happy to add |
|
Oh wow, thanks for the clarification, that seems obvious now that I think about it, I had a look at the source and probably would have realized this if I was more familiar with how Anyway, I appreciate the super fast followup with PR 273, that adds clarity and directly addresses the flag in question. Fantastic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a statement in the README about command-line arguments that are not node-dev options "are passed on to the node process."
In practice this is not the case and passing Node arguments such as
--preserve-symlinksresults in the process exiting with an AssertionError (see screenshot below).Screenshot