[ESM] Detect modules with get-package-type (#201) #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to see a test for this. Can you try to add one? |
|
@bjornstar yes I will do that. I first wanted to check if it's going in the right direction before spending more time on it. |
|
@bjornstar test added! |
bjornstar
reviewed
Mar 22, 2022
bjornstar
reviewed
Mar 22, 2022
| @@ -94,7 +95,7 @@ module.exports = function ( | |||
| isPaused = false; | |||
| const cmd = nodeArgs.concat(wrapper, script, scriptArgs); | |||
|
|
|||
| if (extname(script) === '.mjs') { | |||
| if (extname(script) === '.mjs' || getPackageType.sync(script) === 'module') { | |||
There was a problem hiding this comment.
This spot is a little more tricky because we have the child in the parent scope.
let's return the isESM promise here and I'll see how I can make it cleaner after it's merged.
There was a problem hiding this comment.
Funnily enough, this spot was the easy one. I just make start() async and await here, and it works, all tests pass.
if (extname(script) === '.mjs' || await getPackageType(script) === 'module') {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the only way to load scripts in module mode is by explicitly adding the
.mjsextension. With this PR, thetypesetting in a project'spackage.jsonfile is also consulted. This will be more and more the way ESM-only projects are to be identified.