suppress experimental warnings on node 18+ #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
got this warning in |
|
is complete? |
|
I confirmed this works on node 18, please approve and merge it! 🍻 |
|
@bjornstar see please ) |
|
Published in v8.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppresses this warning that occurs every time you use
node-dev:Also I'm pretty sure the
--no-warningsoption does nothing, since the function that suppresses the warnings is always called. Not sure if that's intentional or not. And the existing unit test for the experimental warning suppression passes even if you omit that flag from thespawn()call.I'm not sure which version of Node actually introduced this warning, but I noticed it when upgrading from Node 16 to 18.
fixes #293