fix page jumping to top when exiting fullscreen mode #4041
Conversation
|
Your demo site is ready! 🚀 Visit it here: https://fgpv-vpgf.github.io/fgpv-vpgf/fix-187/samples/index-samples.html |
There was a problem hiding this comment.
Seems to be working for me when using esc to exit full screen but not when using the full screen sidenav button to exit (issue persists).
Reviewable status: 0 of 2 files reviewed, all discussions resolved
RyanCoulsonCA
force-pushed
the
fix-187
branch
from
a97c312
to
0270f99
Compare
There was a problem hiding this comment.
Should be fixed now. I guess pressing the button caused the escape handler to be called twice, so it was jumping to the element and then back to the top when it was called the second time.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
Closes ramp4-pcar4/story-ramp#187
This PR fixes an issue where the page jumps back to the top after exiting fullscreen. Now when you exit the page will jump to the map that was set to full screen.
For testing purposes, I've modified the
index-many-2.htmltest page to display maps vertically. I can change this back once testing is complete. Try full screening each of these and ensure the page jumps to the correct map when you exit. You can also play around with other samples to make sure this works for those too.This change is