Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rv-lightbox-dialog close button #4069

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

spencerwahl
Copy link
Member

@spencerwahl spencerwahl commented Oct 28, 2022

Fixes the close button positioning on rv-lightbox-dialogs (the popout image when you click on one in the details panel).

Fixed button:
image


This change is Reviewable

@github-actions
Copy link

Your demo site is ready! 🚀 Visit it here: https://fgpv-vpgf.github.io/fgpv-vpgf/details-images/samples/index-samples.html

Copy link
Contributor

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

Copy link
Contributor

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @spencerwahl)

@spencerwahl spencerwahl merged commit 2e97b9e into fgpv-vpgf:develop Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants