Skip to content

Commit

Permalink
work around lack of Rack::MethodOverride in Rails api by artifically …
Browse files Browse the repository at this point in the history
…accepting _method: delete
  • Loading branch information
travis committed Jun 29, 2019
1 parent 92246ca commit 793b4e8
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 3 deletions.
8 changes: 6 additions & 2 deletions config/routes.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# frozen_string_literal: true

LetterOpenerWeb::Engine.routes.draw do
delete 'clear' => 'letters#clear', as: :clear_letters
delete ':id' => 'letters#destroy', as: :delete_letter
delete_pseudo_method_constraint = ->(req) { req.params['_method'] == 'delete' }

delete 'clear' => 'letters#clear', as: :clear_letters
post 'clear' => 'letters#clear', constraints: delete_pseudo_method_constraint
delete ':id' => 'letters#destroy', as: :delete_letter
post ':id' => 'letters#destroy', constraints: delete_pseudo_method_constraint
get '/' => 'letters#index', as: :letters
get ':id(/:style)' => 'letters#show', as: :letter
get ':id/attachments/:file' => 'letters#attachment'
Expand Down
12 changes: 11 additions & 1 deletion spec/controllers/letter_opener_web/letters_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -112,15 +112,25 @@
delete :clear
expect(response).to redirect_to(letters_path)
end

it 'works with a post and _method: delete pseudo delete method' do
post :clear, params: { _method: 'delete' }
expect(response).to redirect_to(letters_path)
end
end

describe 'DELETE destroy' do
let(:id) { 'an-id' }
before { allow_any_instance_of(LetterOpenerWeb::Letter).to receive(:exists?).and_return(true) }

it 'removes the selected letter' do
allow_any_instance_of(LetterOpenerWeb::Letter).to receive(:exists?).and_return(true)
expect_any_instance_of(LetterOpenerWeb::Letter).to receive(:delete)
delete :destroy, params: { id: id }
end

it 'works with a post and _method: delete pseudo delete method' do
expect_any_instance_of(LetterOpenerWeb::Letter).to receive(:delete)
post :destroy, params: { _method: 'delete', id: id }
end
end
end

0 comments on commit 793b4e8

Please sign in to comment.