Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rexml gem into dependency for Ruby 3.0 #106

Closed
wants to merge 1 commit into from

Conversation

tricknotes
Copy link
Contributor

It has been removed from default gems since Ruby 3.0.
Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

To use it via bundler, we should specify it as dependency.

It has been removed from default gems since Ruby 3.0.
Ref: https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/

To use it via bundler, we should specify it as dependency.
@codecov-io
Copy link

Codecov Report

Merging #106 (ab4875e) into master (968d1a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          23       23           
  Lines         335      335           
=======================================
  Hits          326      326           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968d1a0...ab4875e. Read the comment docs.

@tricknotes
Copy link
Contributor Author

@fgrehm How do you feel about this PR?

@tricknotes
Copy link
Contributor Author

@fgrehm Could you review this PR ?

@fgrehm
Copy link
Owner

fgrehm commented Oct 6, 2021

Hey @tricknotes! sorry for the delay here, this PR is in for the next major release of the gem which I hope to release at some point this week :) https://github.com/fgrehm/letter_opener_web/compare/next

@tricknotes
Copy link
Contributor Author

Good to know! Thank you!

@fgrehm fgrehm mentioned this pull request Oct 20, 2021
16 tasks
@fgrehm
Copy link
Owner

fgrehm commented Oct 20, 2021

Hey @tricknotes! If you have the time, it'd be great if you could give that PR above a try, tks in advance!

@fgrehm
Copy link
Owner

fgrehm commented Oct 28, 2021

Just got a pre-release ready to go. Please give that a try when you get a chance and I'll also just ping some folks for testing before a final release. This PR should auto close after code is on master.

Thanks for your contribution!

@fgrehm
Copy link
Owner

fgrehm commented Nov 6, 2021

Closed by #113

@fgrehm fgrehm closed this Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants