Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails' built-in CSRF protection #111

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Conversation

dee-see
Copy link
Contributor

@dee-see dee-see commented Oct 13, 2021

The HTML contains the anti-CSRF token in

however the protect_from_forgery call was missing from ApplicationController.

@fgrehm fgrehm mentioned this pull request Oct 20, 2021
16 tasks
@fgrehm
Copy link
Owner

fgrehm commented Oct 20, 2021

Hey @dee-see , just a heads up that this is something that will come along with the upcoming 2.0 I got in the works, see the PR linked above for more.

If you have the time, it'd be great if you could give that branch a try as well, tks in advance!

@fgrehm
Copy link
Owner

fgrehm commented Oct 28, 2021

Just got a pre-release ready to go. Please give that a try when you get a chance and I'll also just ping more folks for testing before a final release. This PR should auto close after code is on master.

Thanks for your contribution!

@dee-see
Copy link
Contributor Author

dee-see commented Oct 28, 2021

Seems to be working well. There's only a clear button now and no way to delete an individual "letter" is that right?

@fgrehm
Copy link
Owner

fgrehm commented Oct 30, 2021

Seems to be working well. There's only a clear button now and no way to delete an individual "letter" is that right?

Good catch! I've updated the TODO list on the PR to remind me of that before final release. If by any chance you or someone else has the time to implement that feel free to submit a PR. I'll also try to get that done next week

fgrehm added a commit that referenced this pull request Oct 30, 2021
@fgrehm
Copy link
Owner

fgrehm commented Nov 1, 2021

Hey @dee-see, just pushed 3ab59e4 and cut a new 2.0.0.pre.beta release of the gem. Please give that a shot when you get a chance and report back in #113 if things look good to ya

@fgrehm fgrehm merged commit 13565e3 into fgrehm:master Nov 6, 2021
luckpooh pushed a commit to luckpooh/letter_opener_web that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants