Allow dot in attachment name #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenharman
changed the title
stevenharman
force-pushed
the
allow_dot_in_attachement_name
branch
from
caf740a
to
a25e056
Compare
|
👋 Hello @fgrehm, and thank you for Thank you, again! |
|
Hey @stevenharman! Sorry for the delay and sure, I could use some help here! |
Moved dev/test dependencies into proper Bundler groups. I also added binstubs for rspec and rubocop - this ensures we're running the right versions of those tools locally.
The default constraint on segments does not allow dot (.) characters, so requests for attachments with a dot in the file name wouldn't find a route, resulting in a 404 out of the Rails router.
stevenharman
force-pushed
the
allow_dot_in_attachement_name
branch
from
a25e056
to
af99799
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change (in its own commit for clarity) is to allow dot (
.) characters in attachment file name. The default constraint on segments does not allow dots, so requests for attachments with a dot in the file name wouldn't find a route, resulting in a 404 out of the Rails router.The other commits are appeasing Rubocop.
An alternative approach
There are likely other characters allowed in file names, but disallowed in the path of a URL. If we'd also like to handle those, we could change the way we pass the attachment file name to use a query param. So the route would change to something like:
The
filenameparam would also be URL encoded to make it safe. If you like this idea, I can adjust this PR to use that approach. Or, just roll with this one as-is and deal with that later, if someone needs it.