Rails 5 updates to LettersController #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would we want to keep before_filter for older versions? |
|
@fgrehm Could this be merged, please? |
|
@fgrehm Waiting for a new release, thx. |
|
Sorry but I no longer use this gem, anyone up for taking it over? 🍺 |
|
Hey @fgrehm, I'd be willing to take this over. Still looking? |
|
ping @fgrehm |
|
@pseudomuto invited! once you have a release ready to go LMK and I'll give you the permissions on rubygems to push there as well. 🍻 |
|
Thanks for the PR @mikeycgto! |
|
happy to help! ❤️ |
|
For anyone waiting on this, version 1.3.1 was just released and includes this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.