Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry on http 408 error ? #63

Closed
Cactusbone opened this issue Oct 31, 2017 · 3 comments
Closed

retry on http 408 error ? #63

Cactusbone opened this issue Oct 31, 2017 · 3 comments
Labels

Comments

@Cactusbone
Copy link

Hi !
Depending on load, we might see some http 408 error (Request Time-out) and I think it's a good code to retry, since it means either the client was to slow to send the request, or the server was too busy to receive it.

What do you think ?

@FGRibreau
Copy link
Owner

If could make sense however I think we should consider it as a breaking change since it changes the default behaviour.

Not sure if we should support it out of the box or ask our users to leverage custom strategies

@Cactusbone
Copy link
Author

Yeah, custom strategy would work. It's indeed a breaking change.
Should i change the PR to provide an alternative strategy so it's easy to use in place of current HTTPOrNetworkError ?

@FGRibreau
Copy link
Owner

@Cactusbone I think you should release it as an outside npm package and I will like it inside the README :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants