Improve SegmentReader API #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having to decode the WAL entries has a huge impact on performance when scanning through WAL segments: $ benchcmp benchmark_old.txt benchmark_new.txt benchcmp is deprecated in favor of benchstat: https://pkg.go.dev/golang.org/x/perf/cmd/benchstat benchmark old ns/op new ns/op delta BenchmarkSegmentReader-8 899279 215627 -76.02% benchmark old allocs new allocs delta BenchmarkSegmentReader-8 12009 5009 -58.29% benchmark old bytes new bytes delta BenchmarkSegmentReader-8 148851 84836 -43.01%
fgrosse
force-pushed
the
segment-reader-next
branch
3 times, most recently
from
e3b1b46
to
6c6265a
Compare
fgrosse
force-pushed
the
segment-reader-next
branch
from
6c6265a
to
22010e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves performance by enabling callers to skip decoding WAL entries if they only want to seek through the WAL up to a specific offset. The changeset contains both new benchmarks as well as refactoring of the package structure to introduce a new
waltestpackage and a folder fortestdatawhich is used in benchmarks.