Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some enhancements! #1

Closed
palmhjell opened this issue Aug 26, 2019 · 6 comments
Closed

Some enhancements! #1

palmhjell opened this issue Aug 26, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@palmhjell
Copy link
Contributor

palmhjell commented Aug 26, 2019

First off just reiterating this is so amazing. I love it.

Okay down to business, in order of decreasing priority/increasing complexity:

  1. In the README, be more specific about how the reverse RefSeq is literally just as easy as it sounds (the 5' to 3' direction of the gene itself). I can make this change, just putting it here for reference.

  2. Output a third file in Summary, which is just the stats for the max in each well. (Easy code, can do it after, but also would be nice to just have.) Then if >95%, feel confident. If lower, check on a case-by-case basis if acceptable or meaningful.

  3. Add more automation in the sequence generation for the RefSeq.csv file. For example, if doing a single plate, allow passing 'all' in the well position, which would specify applying the ref sequences for all wells in a plate (A–H, 1–12). Or pass a list of plates if doing more than one.

  4. Let the parser read zipped files. (This may be as simple as just changing the function used for reading... https://stackoverflow.com/questions/12902540/read-from-a-gzip-file-in-python. It also might not...)

@palmhjell palmhjell added the enhancement New feature or request label Aug 26, 2019
@kadinaj
Copy link
Contributor

kadinaj commented Aug 26, 2019

  1. Building off the RefSeq comment, you can make it clearer where you should start with the sequence. Ex. from the beginning of the primer, from the end of the primer, etc.

  2. Building off of Patrick's Parameters #3, I agree. Maybe you could have a small script here that autogenerates this csv for you since really the only information I needed to provide (at least for a single plate) was the (1) name, (2) number of variable positions, (3) forward sequence, (4) reverse sequence.

@palmhjell
Copy link
Contributor Author

Agreed @kadinaj. I'm going to make a branch and quickly address #1, #2, and #4 since those are very easy. #3 should be its own thing since it's a bit more involved.

@kadinaj
Copy link
Contributor

kadinaj commented Aug 26, 2019

  1. Pass the file location of the GlobalParams.txt file when calling the program so that you can avoid needing to have it in the same folder as the script

@palmhjell
Copy link
Contributor Author

We should also make the Summary outputs include the actual codons at each position, since L and I (?) have two possible codons and that can very possibly make a difference in activity. (Or, if we don't use the 22c trick, it would be more critical.)

@palmhjell
Copy link
Contributor Author

Moved the 3rd issue here to a new stand-alone issue (#3).

@palmhjell
Copy link
Contributor Author

Closing for next round of updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants