Replace cchardet with the Python 3.11.x compatible faust-cchardet #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
thanks for all your work on
news-please. We recently looked into bumping our production setup to Python 3.11 and realized that there is a transitive dependency that holds us back. I wonder if you would be willing to merge this PR to support Python 3.11 and onwards.AFAIK,
cchardetis not actively maintained, and lacks support for Python 3.11.x. There is a drop-in replacement in the form of thefaust-cchardetpackage that other package maintainers seem to adopt (mailgun/talon#233). The forkednews-pleaserepo passes our CI with these changes, but let me know if there are any other concerns from your side.Thank You,
Hannes