Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New v0.8 release does not compile on Debian Jessie #32

Closed
tssajo opened this issue Jun 25, 2017 · 6 comments
Closed

New v0.8 release does not compile on Debian Jessie #32

tssajo opened this issue Jun 25, 2017 · 6 comments

Comments

@tssajo
Copy link
Contributor

tssajo commented Jun 25, 2017

Previous versions compiled fine. The latest release gives me this error:

...
cp pngusr.h libpng/pngusr.h
make -C libpng/ -f scripts/makefile.gcc CC="gcc" CFLAGS="-Ofast -std=gnu11 -msse4.2 -mpclmul -DPNG_USER_CONFIG -Wno-macro-redefined" libpng.a
make[1]: Entering directory '/home/user/dists/Efficient-Compression-Tool-0.8/src/libpng'
make[1]: scripts/makefile.gcc: No such file or directory
make[1]: *** No rule to make target 'scripts/makefile.gcc'.  Stop.
make[1]: Leaving directory '/home/user/dists/Efficient-Compression-Tool-0.8/src/libpng'
Makefile:33: recipe for target 'libpng' failed
make: *** [libpng] Error 2

Checking the contents of directory src/libpng :

# ls -alsh Efficient-Compression-Tool-0.8/src/libpng
total 12K
4.0K drwxrwxr-x  2 root root 4.0K Jun 25 20:08 .
4.0K drwxrwxr-x 10 root root 4.0K Jun 25 16:29 ..
4.0K -rw-r--r--  1 root root 3.2K Jun 25 20:08 pngusr.h

There is only one file??!

gcc version is:

# gcc --version
gcc (Debian 4.9.2-10) 4.9.2
Copyright (C) 2014 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
@AlyoshaVasilieva
Copy link
Contributor

Did you perform recursive clone to retrieve ECT source?

@tssajo
Copy link
Contributor Author

tssajo commented Jun 26, 2017

@AlyoshaVasilieva No, I downloaded v0.8.tar.gz file from this page:
https://github.com/fhanau/Efficient-Compression-Tool/releases/tag/v0.8

( Direct link to the file: https://github.com/fhanau/Efficient-Compression-Tool/archive/v0.8.tar.gz )

After tar xf v0.8.tar.gz the Efficient-Compression-Tool-0.8/src/libpng directory is empty.

@tssajo
Copy link
Contributor Author

tssajo commented Jun 26, 2017

@AlyoshaVasilieva Doing this helped with the above issue:

tar xf v0.8.tar.gz && cd Efficient-Compression-Tool-0.8/src && git clone https://github.com/glennrp/libpng.git

Now the libpng directory is no longer empty.

However, later there is another compilation error:

...
In file included from support.cpp:9:0:
support.h:23:1: error: ‘time_t’ does not name a type
 time_t get_file_time(const char* Infile);
 ^
support.h:25:40: error: ‘time_t’ has not been declared
 void set_file_time(const char* Infile, time_t otime);
                                        ^
...
Makefile:22: recipe for target 'bin' failed
make: *** [bin] Error 1

Can you help with this one?

@tssajo
Copy link
Contributor Author

tssajo commented Jun 26, 2017

I managed to fix the support.h:23:1: error: ‘time_t’ does not name a type compilation error.

I created a pull request with the fix:
#33

@tssajo
Copy link
Contributor Author

tssajo commented Jun 26, 2017

I close this now. Although it is annoying that that source release file ( https://github.com/fhanau/Efficient-Compression-Tool/archive/v0.8.1.tar.gz ) has an empty Efficient-Compression-Tool-0.8.1/src/libpng directory and git must be used to clone that before the package can be compiled.

At least this should be documented somewhere, in a README file, or something.

@tssajo tssajo closed this as completed Jun 26, 2017
@fhanau
Copy link
Owner

fhanau commented Jun 27, 2017

I added some info about this in 7b3786b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants