Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--disable-png and --disable-jpg are ignored when -gzip is given. #133

Closed
danjujan opened this issue Sep 13, 2023 · 2 comments
Closed

--disable-png and --disable-jpg are ignored when -gzip is given. #133

danjujan opened this issue Sep 13, 2023 · 2 comments

Comments

@danjujan
Copy link

I noticed that the -gzip command line option interacts with --disable-png or --disable-jpg:

./ect --disable-png --disable-jpg image.png image.jpg
No compatible files found

./ect -gzip --disable-png --disable-jpg image.png image.jpg
Processed 2 files
Saved 40.77KB out of 276.14KB (14.7637%)

Is this intended behavior?

@fhanau
Copy link
Owner

fhanau commented Sep 24, 2023

Hi, the --disable-* flags were designed to disable optimizing the given file formats. This isn't working correctly here - I'll prepare a fix in the coming days.

@fhanau fhanau closed this as completed in 380a1df Oct 23, 2023
@fhanau
Copy link
Owner

fhanau commented Oct 23, 2023

Fixed the issue – ECT will now respect the disable flags and not compress the specified files, but create a gzip archive.
Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants