Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(urls): provide two collections of urls - 'simple' urls and 'complete' urls #278

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fhightower
Copy link
Owner

@fhightower fhightower commented Dec 13, 2022

Move the data currently captured in urls to urls_complete and populate urls with 'simple' URLs which are likely to be used in the wild and identified as such by humans.

Fixes #261

Todo:

  • I think some of the changes I've previously made to the URL grammar to move away from the RFC to better handle natural language can be ported back into the grammar as we move it to urls_complete

@fhightower fhightower changed the title feat(urls): provide two collections of urls feat(urls): provide two collections of urls - 'simple' urls and 'complete' urls Dec 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (98759b3) 100.00% compared to head (8fe6c56) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          408       422   +14     
=========================================
+ Hits           408       422   +14     
Impacted Files Coverage Δ
ioc_finder/ioc_finder.py 100.00% <100.00%> (ø)
ioc_finder/ioc_grammars.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve URL boundary regarding commas (Old name: Wrong URL Pattern being Parsed)
2 participants