Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging is leaking credentials to logs #74

Closed
mtparet opened this issue Dec 22, 2017 · 2 comments
Closed

Logging is leaking credentials to logs #74

mtparet opened this issue Dec 22, 2017 · 2 comments

Comments

@mtparet
Copy link
Contributor

mtparet commented Dec 22, 2017

For all requests, the gem records the request including headers with secrets in logs. https://github.com/fhir-crucible/fhir_client/blob/master/lib/fhir_client/client.rb#L334
Should we set the logging level to debug for these logs (production environment should not run in debug) ? Or should we have a logging that remove/select the secrets/data ?

@jawalonoski
Copy link
Member

I'm not sure which secrets are leaking under what conditions. If you'd like to submit a pull request to remove secrets data, we'd happily review it. I'm also open to changing the log level to debug.

@mtparet
Copy link
Contributor Author

mtparet commented Jan 2, 2018

Thank you, I opened a PR to change the log level to debug for the request/response logging.

jawalonoski added a commit that referenced this issue Jan 4, 2018
Fix #74 Change some log levels from info to debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants