Skip to content

Commit

Permalink
Don't use pipe via console on windows, fixes unclebob#989
Browse files Browse the repository at this point in the history
  • Loading branch information
fhoeben committed Dec 4, 2016
1 parent b2ecf92 commit 3bb4b0c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/fitnesse/testsystems/slim/SlimClientBuilder.java
Expand Up @@ -14,6 +14,7 @@
import fitnesse.socketservice.PlainServerSocketFactory;
import fitnesse.socketservice.SslClientSocketFactory;
import fitnesse.testsystems.*;
import org.apache.commons.lang.SystemUtils;

public class SlimClientBuilder extends ClientBuilder<SlimCommandRunningClient> {
public static final String SLIM_PORT = "SLIM_PORT";
Expand Down Expand Up @@ -78,7 +79,7 @@ public void write(String output) {
/**
* This reverts the wrap that the LoggingOutputStream.flush method
* is doing.
*
*
* @param prefixedMessage
* @param level
* @return == null : the message is not prefixed with the given
Expand Down Expand Up @@ -226,7 +227,9 @@ private int getSlimPortBase() {
} catch (NumberFormatException e) {
// stick with default
}
return SLIM_USE_PIPE_PORT;
// Windows console does not support Unicode (by default)
// so we use a socket by default on Windows.
return SystemUtils.IS_OS_WINDOWS ? 0 : SLIM_USE_PIPE_PORT;
}

private int getSlimPortPoolSize() {
Expand Down

0 comments on commit 3bb4b0c

Please sign in to comment.