-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.13.0 release build is not reproducible #316
Comments
@hboutemy I upgraded my maven version, source and java doc plugin. I hope that helps. I can't seem to follow the steps to check locally. When I try to use the buildinfo plugin I get the following error: Any thoughts how I should proceed? |
@fhoeben sorry, I overlooked your answer IMHO, the easiest way to check is to checkout reproducible-central repository and reproduce by running
the only prerequisite is Docker you'll see at the end:
then you can go to when I do it on my machine, I get difference on generated
|
@hboutemy thanks for the clarification. These files are generated by a plugin that I did not even consider when thinking about reproducible builds. It just shows how great it is to have automated checks! |
I'm looking into praegus/fixture-doc-generator#1 but can't seem to reproduce the steps described above on windows or wsl. Is it possible to get an actual diff of th egenerated jsons? That would help me analyze what happens, as I can't immediately figure out what would cause the difference Edit: nvm, got it running after converting my distro to wsl2 |
It seems the actual difference is caused by some charset issue:
I think we should be able to prevent this by specifying the charset to be used somewhere, but a quick fix that prevents the reproduction from failing is to replace the (wrongly typed) 'ç' with 'c'. (see: #354) |
Thanks for the quick pickup @tcnh! Maybe that ç was not in UTF-8? |
Could be. The funny thing is that the jsons in the reference contained '?enter', and the reproduction from the container contained 'çenter'.. Possibly some environment setting on the gitlab runner? |
I didn't check in detail but I assume the reference was from maven central, which I probably built on my mac... (still haven't set up the pipeline to publish to central) |
Hi, Then the sad news:
the remaining issues are much easier to understand: the job you did on the main jar file is awesome |
@hboutemy Thanks for the feedback. I will try to look at the remaining issues. Especially the extra files in the standalone are interesting: I would like to keep this as small as possible so less files seems better. Maybe something wrong in my local build process. Do you have a list of missing files? |
|
* remove typo from javadoc comment (cause of reproducibility issue #316) * Update toolchain-plugin to 2.0.14
see rebuild result on https://github.com/jvm-repo-rebuild/reproducible-central
The text was updated successfully, but these errors were encountered: