fix null ref exception on CLRv2 in DLR.fs #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this in response to a bug? If so, what was the repro case? I'd like to take a look and make sure that this fixes it. |
|
Sorry I did not create a bug for this, I just noticed it when I attempted to run the REPL utility and it seems that the DebugView property is not present in CLRv2, it first appeared in v4 so it made sense. I believe that code is attempting to pull the debug view info for the expression tree and print it; my change just uses a blank value if reflection doesn't find the DebugView property. |
otac0n
added a commit
that referenced
this pull request
Jan 4, 2012
fix null ref exception on CLRv2 in DLR.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at a git pull request, hope this works.