Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OA-Streams: Introduction of Cluster's Size #22

Merged
merged 12 commits into from
May 27, 2024
Merged

OA-Streams: Introduction of Cluster's Size #22

merged 12 commits into from
May 27, 2024

Conversation

steveyuwono
Copy link
Collaborator

Description

Background

Checklists:

  • Read the CONTRIBUTION guide (required).
  • Update the history on the source code (required).

@steveyuwono steveyuwono added enhancement New feature or request OA Online Adaptivity labels May 25, 2024
@steveyuwono steveyuwono self-assigned this May 25, 2024
@steveyuwono steveyuwono marked this pull request as draft May 25, 2024 11:15
@steveyuwono steveyuwono linked an issue May 25, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@detlefarend detlefarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @steveyuwono, I just took a look at your extensions. It looks good and should perfectly solve the problem. I just have a hint about using the MLPro properties. These have four different attributes:

2024-05-26_10-26

These, in turn, are Python properties, which means they can be accessed as public attributes but implicitly call get/set methods.

To access the value of new MLPro property 'size' as intended you can say

2024-05-26_10-21

instead of

2024-05-26_10-16

There is actually just one reason for using the public method set: if you want to provide an explicit timestamp.

@steveyuwono
Copy link
Collaborator Author

Hi @steveyuwono, I just took a look at your extensions. It looks good and should perfectly solve the problem. I just have a hint about using the MLPro properties. These have four different attributes:

2024-05-26_10-26

These, in turn, are Python properties, which means they can be accessed as public attributes but implicitly call get/set methods.

To access the value of new MLPro property 'size' as intended you can say

2024-05-26_10-21

instead of

2024-05-26_10-16

There is actually just one reason for using the public method set: if you want to provide an explicit timestamp.

Hi Detlef, thank you for your review. Ahh sorry, we have discussed this but I forgot. It has now been updated accordingly.

@detlefarend
Copy link
Member

detlefarend commented May 27, 2024

@steveyuwono could you please also extend the oa howtos by printing the sizes of the clusters at the end?

@steveyuwono
Copy link
Collaborator Author

@steveyuwono could you please also extend the oa howtos by printing the sizes of the clusters at the end?

I have done it in howto_oa_wr 001 to 005. Do all howto_oa_ca_* also need this extension?

@detlefarend
Copy link
Member

@steveyuwono could you please also extend the oa howtos by printing the sizes of the clusters at the end?

I have done it in howto_oa_wr 001 to 005. Do all howto_oa_ca_* also need this extension?

Hi Steve, yes please. Thank you!

@steveyuwono
Copy link
Collaborator Author

@steveyuwono could you please also extend the oa howtos by printing the sizes of the clusters at the end?

I have done it in howto_oa_wr 001 to 005. Do all howto_oa_ca_* also need this extension?

Hi Steve, yes please. Thank you!

@steveyuwono could you please also extend the oa howtos by printing the sizes of the clusters at the end?

I have done it in howto_oa_wr 001 to 005. Do all howto_oa_ca_* also need this extension?

Hi Steve, yes please. Thank you!

Okay, the updates have been made.

@detlefarend detlefarend marked this pull request as ready for review May 27, 2024 09:42
@detlefarend detlefarend merged commit 6f87986 into main May 27, 2024
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OA Online Adaptivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper CA: Management of new cluster property 'size'
2 participants