Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in dark theme, gitalk comment container has close color and background-color #344

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

lulu010722
Copy link
Contributor

When you use gitalk in archer's dark mode, the textarea, preview container and the comment content container all have similar color and background color setting. This makes it very hard to see the text.

I have reformatted the dark.css under source\css.
The lines that are really changed are 420 - 424.

@LolipopJ
Copy link
Collaborator

Thanks for contributing! 🥰

@LolipopJ LolipopJ merged commit ffb0dad into fi3ework:master Sep 18, 2022
@LolipopJ
Copy link
Collaborator

LolipopJ commented Sep 18, 2022

奥,有个小问题:不应该直接修改 source/css 目录下的文件,主题构建的时候会使用 src/scss 目录下的 .scss 样式文件来生成 source/css 中的 .css 样式文件。

可以参考这个(简易)指南,其中与 Gitalk 相关的暗黑模式样式需要修改此文件

@lulu010722
Copy link
Contributor Author

啊不好意思,我对scss不太熟悉,我在本地改了css看到生效了就直接fork然后push了哈哈哈哈哈。
你已经merge了啊?
可以用么?
还需要改么?

@LolipopJ
Copy link
Collaborator

啊不好意思,我对scss不太熟悉,我在本地改了css看到生效了就直接fork然后push了哈哈哈哈哈。 你已经merge了啊? 可以用么? 还需要改么?

需要改一下的,不然下次构建的时候就会把你改动的地方覆盖掉了。source 目录下的文件都是工程自动生成的。

改好后发一个新的 PR 吧。🥲

@lulu010722
Copy link
Contributor Author

啊不好意思,我对scss不太熟悉,我在本地改了css看到生效了就直接fork然后push了哈哈哈哈哈。 你已经merge了啊? 可以用么? 还需要改么?

需要改一下的,不然下次构建的时候就会把你改动的地方覆盖掉了。source 目录下的文件都是工程自动生成的。

改好后发一个新的 PR 吧。🥲

好的。
另外,我又发现了一个问题,已经提交了issue。
(今天是被archer搞疯掉的一天。。)

lulu010722 added a commit to lulu010722/hexo-theme-archer that referenced this pull request Sep 18, 2022
lulu010722 added a commit to lulu010722/hexo-theme-archer that referenced this pull request Sep 18, 2022
Stark-X added a commit that referenced this pull request Sep 19, 2022
fix: use `#333` as gt comment container color mentions in #344
Stark-X pushed a commit to Stark-X/hexo-theme-archer that referenced this pull request Apr 1, 2024
fix: in dark theme, gitalk comment container has close color and background-color
Stark-X pushed a commit to Stark-X/hexo-theme-archer that referenced this pull request Apr 1, 2024
Stark-X added a commit to Stark-X/hexo-theme-archer that referenced this pull request Apr 1, 2024
fix: use `fi3ework#333` as gt comment container color mentions in fi3ework#344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants