New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

References to checker plugin in production build #112

Closed

Grisu118 opened this issue Feb 11, 2022 · 1 comment

Grisu118 commented Feb 11, 2022

The new version 0.4.0 adds the following line to the index.html

<script type="module">import { inject } from "/@vite-plugin-checker-runtime"; inject();</script>

This is done also for a production build, in my eyes this is wrong and should only happen for dev builds.

fi3ework added a commit that referenced this issue


          fix: runtime should not be bundled in build mode (#112)

b7fd2e3

fi3ework added a commit that referenced this issue


          fix: runtime should not be bundled in build mode (#112)

0330ab2

Owner

fi3ework commented Feb 11, 2022

@Grisu118 Sorry for my stupid mistake 😅. I made a hotfix and published 0.4.1. I'll add a test case for this issue later. Thanks for your good catch! Please upgrade to 0.4.1 🤗. https://github.com/fi3ework/vite-plugin-checker/blob/main/packages/vite-plugin-checker/CHANGELOG.md#041-2022-02-11

fi3ework closed this as completed

fi3ework mentioned this issue

test: add case for no runtime code in build #114

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment