Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional global configuration of root directory #262

Merged
merged 1 commit into from
Jul 24, 2023
Merged

feat: add optional global configuration of root directory #262

merged 1 commit into from
Jul 24, 2023

Conversation

art0rz
Copy link
Contributor

@art0rz art0rz commented Jul 21, 2023

This MR adds a new optional configuration property root

In our project, we want some checkers to run in a different root directory. This property enables us to do so.

checker({
	root: path.resolve(__dirname, "../foo"),
	typescript: true,
	eslint: {
		lintCommand: 'eslint "**/*.{js,ts,tsx}" --cache --max-warnings 0',
	},
}),

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

⚠️ No Changeset found

Latest commit: eaa76fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 21, 2023

Deploy Preview for vite-plugin-checker ready!

Name Link
🔨 Latest commit eaa76fc
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-checker/deploys/64ba3239b77cd300088b8130
😎 Deploy Preview https://deploy-preview-262--vite-plugin-checker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework
Copy link
Owner

Thanks!

@fi3ework fi3ework merged commit e564641 into fi3ework:main Jul 24, 2023
9 of 10 checks passed
@art0rz
Copy link
Contributor Author

art0rz commented Jul 26, 2023

when do you think this will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants