Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Brazilian standard require idNumber, back document and email fo… #85

Closed
wants to merge 7 commits into from
Closed

feat: Brazilian standard require idNumber, back document and email fo… #85

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
421ad53
feat: Brazilian standard require idNumber, back document and email fo…
ailsoncgt Nov 18, 2022
e834177
fix: indentation
ailsoncgt Nov 21, 2022
0ff71de
feat(kyc): new kyc schema with back doc
ailsoncgt Nov 25, 2022
48d216c
fix: indentation
ailsoncgt Nov 25, 2022
e2c9d58
fix: add more info about fields
ailsoncgt Nov 29, 2022
b29d830
feat(kyc): add accepted docs
ailsoncgt Jan 4, 2023
795dc78
feat(kyc): remove idNumber
ailsoncgt Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions fiatconnect-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2226,12 +2226,15 @@ A KYC schema containing personal data about a user, as well as documents such as
postalCode?: `string`
},
phoneNumber: `string`,
idNumber?: `string`,
email?: `string`,
selfieDocument: `string`,
identificationDocument: `string`
identificationDocument: `string`,
identificationDocumentBack?: `string`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you require idNumber, email, and identificationDocumentBack, then they shouldn't be optional fields. The question mark indicates that the field is optional.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I recommend that you create a new KYC schema for these fields, rather than tacking them onto an existing one. Adding a new KYC schema is a non-breaking change, since clients can incrementally add support for new schemas without breaking their existing integrations. However, changing an existing KYC schema is generally a breaking change, and something to avoid without some compelling reason for it

}
```

The `selfieDocument` and `identificationDocument` fields should be base64 encoded binary blobs representing images.
The `selfieDocument`, `identificationDocument` and `identificationDocumentBack` fields should be base64 encoded binary blobs representing images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some more detailed information on the fields required in this schema? (For example, how phoneNumber should be formatted, what the idNumber represents and how it should be formatted, etc.) It might seem a bit pedantic but it's important that we document the exact syntax of these fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @jophish , I will do that.


### 9.3.2. Fiat Account Schemas

Expand Down