Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nos2x Redesign #15

Closed
wants to merge 1 commit into from
Closed

Nos2x Redesign #15

wants to merge 1 commit into from

Conversation

Flydexo
Copy link

@Flydexo Flydexo commented Dec 23, 2022

Hi, I wanted to redesign the extension which is a little bit ugly

So here is the figma file: https://www.figma.com/file/04tjsv8qfWV6eeew73qbaX/Nos2x?node-id=2%3A141&t=gZQRRpXb5VRp3hpJ-1

I will implement all this on code tomorrow. Feel free to request edit on the figma file and comment on this PR so I can edit UI stuff if you don't like it.

I also introduced a new logo and brand design. You can check it on readme

And Happy Christmas

@fiatjaf
Copy link
Owner

fiatjaf commented Dec 23, 2022

I like the design, please go for it. Are you also going to redesign the options page?
Feel free to delete the existing screenshots.

@Flydexo
Copy link
Author

Flydexo commented Dec 23, 2022

I think the option page should be placed inside the popup because not very easy to find for a beginner, but if we keep it yes I will redesign it

@diegogurpegui
Copy link

I like the idea of a redesign. I was just starting to do something like this but I found this PR. Luckily for all of us because my design was no close to this 😂
One of the screens that needs to be worked on for a better UI is the "prompt".

I'm guessing this is going to be done for Chrome. So I can then work on adapting it to Firefox.

@diegogurpegui
Copy link

diegogurpegui commented Jan 8, 2023

I already been working in a Firefox fork for this extension, and I started implementing your design @Flydexo.
Feel free to take a look at the code in this branch in case it helps: https://github.com/diegogurpegui/nos2x-fox/tree/rebrand-ui

@sebastiansieber
Copy link

@Flydexo please continue your work on this :)

@fiatjaf
Copy link
Owner

fiatjaf commented Jan 26, 2023

@Flydexo have you started working on this? If you don't, notice I am having second thoughts about accepting the contribution. I think it will increase the burden of maintenance going forward (i.e. I won't be able to add a new feature without breaking the design), so maybe it is better if you focus on @diegogurpegui's extension which is already using your designs.

@Flydexo
Copy link
Author

Flydexo commented Feb 1, 2023

Sorry for the inactivity, won't be able to implement for the moment

@fiatjaf
Copy link
Owner

fiatjaf commented Feb 1, 2023

OK, great news. Thank you for your initiative. Be sure to join https://t.me/nostrdesign when you have some time.

@fiatjaf fiatjaf closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants