Unify generics code #297
Closed
Unify generics code #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator interface in generic.go file in core package. Created genericIterator.go file in util package. Added GenericIterator type implemented Iterator interface in genericIterator.go file in util package. Implemented CurrentData, HasNext and Next methods of GenericIterator type in util package. Created NewGenericIterator function in util package.
…ype using util.GenericIterator in cipher.go file in skycoin package. Created NewSkycoinAddressIterator function in cipher.go file in skycoin package. Reimplemented all SkycoinAddressIterator implementation.
…to genericIterator.
…queda_t290_Generic # Conflicts: # src/models/modelWallets.go
…s methods in util package.
|
@stdevHsequeda good , will take a look into this shortly |
FiberCrypto wallet - Iteration 2
automation
moved this from In progress
to Review in progress
Dec 24, 2019
olemis
requested changes
Dec 24, 2019
|
|
||
| // Iterator defines a generic iterator. | ||
| type Iterator interface { | ||
| CurrentData(interface{}) error |
There was a problem hiding this comment.
To Value() interface?
Returns if call to ScanUnspentOutputs fails
…elWallets.loadModel ... ... rather than halting the cycle
…ve_outputs_bug Fixes fibercrypto#302 - Solve outputs bug
|
I'm starting to hesitate about whether moving forward with this is a good idea |
|
I am not satisfied with the approaches I've seen so far ... Let's keep things the way they are now and reopen this should situation change at some point later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
Changes:
-Added Iterator interface.
-Implementing Iterator interface in util packege with GenericIterator type.
-Replaced all old iterators implementation for GenericIterator.
-Added test and comments for GenericIterator type.
Does this change need to mentioned in CHANGELOG.md?
no
Requires testing
Requires testing
no
Comments about testing , should you have some