Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when outputs view opened #302

Closed
AntiD2ta opened this issue Dec 26, 2019 · 1 comment · Fixed by #303
Closed

Crash when outputs view opened #302

AntiD2ta opened this issue Dec 26, 2019 · 1 comment · Fixed by #303
Assignees
@AntiD2ta
Labels
bug Something isn't working gui Problem with the Graphic User Interface stdev wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
Milestone
0.27.0

Comments

@AntiD2ta
Copy link
Contributor

Describe the bug
Crash when outputs view opened.

Steps to Reproduce

  1. Run the wallet offline or with local data not updated
  2. Go for outputs
  3. See error(app terminates with panic)(SIGSEGV)

Actual behavior
App crashes when outputs view opened and app is not synchronized or without connection.

Expected behavior
A busy indicator if it the data is being getted or show no data if there is no outputs in wallets.

Possible implementation
Catch the error, log it, and display a busy indicator if the request for outputs to API fails.
@AntiD2ta AntiD2ta added bug Something isn't working stdev gui Problem with the Graphic User Interface labels Dec 26, 2019
@AntiD2ta AntiD2ta added this to the 0.27.0 milestone Dec 26, 2019
@AntiD2ta AntiD2ta self-assigned this Dec 26, 2019
@AntiD2ta AntiD2ta added this to To do in FiberCrypto wallet - Iteration 1 via automation Dec 26, 2019
@stdevMac
Copy link
Member

@stdevAntiD2ta Should solved in develop

AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Dec 26, 2019
@AntiD2ta
[outputs] refs fibercrypto#302 - Solve bug
d930ba1 
Returns if call to ScanUnspentOutputs fails
@AntiD2ta AntiD2ta added the wip Work in progress label Dec 26, 2019
@AntiD2ta AntiD2ta mentioned this issue Dec 26, 2019
Merged
olemis added a commit to simelo/fibercryptowallet that referenced this issue Dec 29, 2019
@olemis
[models] refs fibercrypto#302 - Skip addresses with no outputs in Mod…
a0664dd 
…elWallets.loadModel ...

... rather than halting the cycle
FiberCrypto wallet - Iteration 1 automation moved this from To do to Done Dec 30, 2019
stdevMac added a commit that referenced this issue Dec 30, 2019
@stdevMac
Merge pull request #303 from simelo/stdevAntiD2ta_t302_Solve_outputs_bug
2399d16 
Fixes #302 - Solve outputs bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntiD2ta AntiD2ta

Labels
bug Something isn't working gui Problem with the Graphic User Interface stdev wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Fixes #302 - Solve outputs bug simelo/fibercryptowallet
2 participants
@stdevMac @AntiD2ta