fixes #279 Continue improving coverage #320

e1Ru1o · 2020-01-24T02:24:02Z

fixes #279

Changes:

Add more tests mainly related with files not covered by the actual test suite
Move mock types for internal Skycoin types onto src/coin/skycoin/skymocks

Does this change need to mentioned in CHANGELOG.md?
no

Requires testing
no, indeed, new tests added

…stination and a Combo box to select log level

I would like a ComboBox with fixed options, but I couldn't do it right

This allows to changes logger properties and propagate this changes across all modules's logger

Changes: - Add SetOutput function to set the desired logger's output given a option - Return error in SetOutputToFile function

…tput Path: skycoin/log/output

… in settings

This need to be upgraded

LALALA log

Writer that write nothing

…tput

… to none

…s when they are saved

Remove SetOutput function and add GetOutputWriter function to return the io.Writer that needs to be given to SetOutputTo function

…ject's logger This occurs when the app's logger change its output

…to 0600

…age' into stdevAntiD2ta_t298_Log_events_to_file

Bug: Return Stderr writer instead of Stdout when option is stdout

Changes: - `TestTransactionIsFullySigned` changed to the new mentioned test with the purpose of be generic

`TestTransactionVerifyUnsigned` and `TestTransactionVerifySigned`

…omTxnHash`

…pentOutput`

…ress`

…oins` to `TestGetCoins` Make the test more generic. Every object with `GetCoins` method could be tested using it

…pent`

Remove other `GetId` test, make a new one generic for all object that have a method `GetId`

…GetSpentOutput`

…nto tests

…age' into stdevRulo_t279_improve_coverage

olemis · 2020-01-28T07:31:27Z

src/coin/mocks/ReadableTxn.go

@@ -0,0 +1,36 @@
+// Code generated by mockery v1.0.0. DO NOT EDIT.


This is an internal interface . No mocks needed .

Usage instances should be replaced with concrete type implementing the internal interface.

Usage instances should be replaced with concrete type implementing the internal interface.

Forget about this previous comment .

The only thing needed is to move this class somewhere under src/coin/skycoin/ sub package tree (e.g. src/coin/skycoin/skymocks) . Code under src/coin/mocks should correspond to types defined in src/core .

olemis · 2020-01-28T07:40:37Z

src/coin/skycoin/models/coin_test.go

+}
+
+func TestEncodeSkycoinTransaction(t *testing.T) {
+	type SkycoinReadableTxn interface {


No need to define this . Use individual types .

olemis · 2020-02-03T21:33:13Z

src/coin/mocks/ReadableTxn.go

@@ -0,0 +1,36 @@
+// Code generated by mockery v1.0.0. DO NOT EDIT.


Usage instances should be replaced with concrete type implementing the internal interface.

Forget about this previous comment .

The only thing needed is to move this class somewhere under src/coin/skycoin/ sub package tree (e.g. src/coin/skycoin/skymocks) . Code under src/coin/mocks should correspond to types defined in src/core .

olemis

There should be a rule in Makefile for generating mocks for internal Skycoin interfaces and place them under src/coin/skycoin subfolder tree .

…do not belong in src/coin/mocks

…kefile target

… Dkycoin altcoin plugin

…ace types

Update test code

AntiD2ta and others added 30 commits January 3, 2020 19:13

[ui] refs fibercrypto#298 - Add Radio Buttons to select log output de…

f03d126

…stination and a Combo box to select log level

[config] refs fibercrypto#298 - Add default configuration for log level

0364ad1

[ui] refs fibercrypto#298 - Add config option for log level

0b39a01

[main] [config] refs fibercrypto#298 - Add log level settings

b956f08

[ui] refs fibercrypto#298 - Add TextField for log Level

7fbc7a7

I would like a ComboBox with fixed options, but I couldn't do it right

Merge branch 'develop' into stdevAntiD2ta_t298_Log_events_to_file

2346a76

[util] refs fibercrypto#298 - Keep references of packages loggers

9cf37c9

This allows to changes logger properties and propagate this changes across all modules's logger

[settings] Add log level as an independent option

9cad3e2

[ui] refs fibercrypto#298 - Change path to log level configuration

a693890

[util] refs fibercrypto#298 - Add function to set log's output to a file

9b97156

[util] refs fibercrypto#298 - Add some changes to logging package

85f0c7e

Changes: - Add SetOutput function to set the desired logger's output given a option - Return error in SetOutputToFile function

[config] refs fibercrypto#298 - Add configuration option for log's ou…

74e7cdd

…tput Path: skycoin/log/output

[main] refs fibercrypto#298 - Set log's output correctly given option…

fca2d43

… in settings

[ui] refs fibercrypto#298 - Add ui to set log's output in Settings

9ea9df3

This need to be upgraded

[ui] - Remove unnecessary qml log

8f7bc72

LALALA log

[logging] refs fibercrypto#298 - Create Writer for none option

4ded230

Writer that write nothing

[logging] refs fibercrypto#298 - Add stderr and none options to SetOu…

8bb88cb

…tput

[config] refs fibercrypto#298 - Change default value for log's output…

f4215c5

… to none

[models] refs fibercrypto#298 - Apply changed settings related to log…

f313996

…s when they are saved

[gitignore] - Ignore .log extensions

c053490

[logging] refs fibercrypto#298 - Refactorize code

a2b05a3

Remove SetOutput function and add GetOutputWriter function to return the io.Writer that needs to be given to SetOutputTo function

[skycoin] [models] refs fibercrypto#298 - Change output of SkycoinPro…

512ec7a

…ject's logger This occurs when the app's logger change its output

[main] - Handle unmarshaling node settings error

40b6449

[makefile] - Improve test-core rule to have a coverage profile

3bf565f

[logging] refs fibercrypto#298 - Change permissions of file for logs …

2cfd783

…to 0600

Merge remote-tracking branch 'simelo_alt/stdevRulo_t279_improve_cover…

99a2875

…age' into stdevAntiD2ta_t298_Log_events_to_file

[config] - Add logs to package config

6803f10

[models] - Add logs to config view model

6e4c5c1

[logging] - Fix bug

fac268e

Bug: Return Stderr writer instead of Stdout when option is stdout

[logging] refs fibercrypto#298 - Add initial tests for logging package

10e5cb0

e1Ru1o and others added 19 commits January 25, 2020 20:37

[test] refs fibercrypto#279 - Add TestTransactionIsFullySigned

30953e4

Changes: - `TestTransactionIsFullySigned` changed to the new mentioned test with the purpose of be generic

[test] refs fibercrypto#279 - Add 2 test

b8a6817

`TestTransactionVerifyUnsigned` and `TestTransactionVerifySigned`

[test] refs fibercrypto#279 - Add `Test_getSkycoinTransactionInputsFr…

eaad386

…omTxnHash`

[test] refs fibercrypto#279 - Update `TestSkycoinTransactionInputGetS…

271e507

…pentOutput`

[test] refs fibercrypto#279 - Add TestSkycoinTransactionInputGetCoins

132ea87

[test] refs fibercrypto#279 - Add `TestSkycoinTransactionOutputGetAdd…

1323485

…ress`

[test] refs fibercrypto#279 - Change `TestSkycoinTransactionInputGetC…

c325bd5

…oins` to `TestGetCoins` Make the test more generic. Every object with `GetCoins` method could be tested using it

[test] refs fibercrypto#279 - Update `TestSkycoinTransactionOutputIsS…

ab7ee72

…pent`

[test] refs fibercrypto#279 - Add TestGet

d078ba0

Remove other `GetId` test, make a new one generic for all object that have a method `GetId`

[test] refs fibercrypto#279 - Update TestGetCoins

433b569

[test] refs fibercrypto#279 - Add `TestSkycoinCreatedTransactionInput…

2a1328c

…GetSpentOutput`

[test] refs fibercrypto#279 - Update GetId

52f4f55

[test] refs fibercrypto#279 - Add generic TestGetAddress

772067c

[test] refs fibercrypto#279 - Add generic TestIsSpent

7982622

[test] refs fibercrypto#279 - Integrate SkycoinCreatedTransaction i…

f6a1552

…nto tests

[test] refs fibercrypto#279 - Add generic TestEncodeSkycoinTransaction

49f3717

[test] refs fibercrypto#279 - Add TestNewWalletNode

595a1c4

[test] refs fibercrypto#279 - GetCoins implementations full covered

fd72907

Merge remote-tracking branch 'simelo_alt/stdevRulo_t279_improve_cover…

8b89c40

…age' into stdevRulo_t279_improve_coverage

olemis requested changes Jan 28, 2020

View reviewed changes

olemis requested changes Feb 3, 2020

View reviewed changes

olemis reviewed Feb 3, 2020

View reviewed changes

olemis added 5 commits February 3, 2020 16:51

[mocks] refs fibercrypto#279 - Mocks for Skycoin-specific interfaces …

88ccf96

…do not belong in src/coin/mocks

[ci] refs fibercrypto#279 - Factor gen-mocks-core out of gen-mocks Ma…

022e5f6

…kefile target

[ci] refs fibercrypto#279 - Generate mocks for internal interfaces of…

d830024

… Dkycoin altcoin plugin

[mocks] refs fibercrypto#279 - Generate mocks for address book interf…

cf6ce80

…ace types

[sky] refs fibercrypto#279 - Generate mocks for Skycoin altcoin plugin

081e56a

Update test code

olemis approved these changes Feb 3, 2020

View reviewed changes

olemis changed the title ~~Refs #279 Continue improving coverage~~ fixes #279 Continue improving coverage Feb 4, 2020

olemis merged commit 2d208ba into fibercrypto:develop Feb 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixes #279 Continue improving coverage #320

fixes #279 Continue improving coverage #320

e1Ru1o commented Jan 24, 2020 •

edited by olemis

Loading

olemis Jan 28, 2020

olemis Jan 28, 2020

olemis Feb 3, 2020

olemis Jan 28, 2020

olemis Feb 3, 2020

olemis left a comment

		@@ -0,0 +1,36 @@
		// Code generated by mockery v1.0.0. DO NOT EDIT.

fixes #279 Continue improving coverage #320

fixes #279 Continue improving coverage #320

Conversation

e1Ru1o commented Jan 24, 2020 • edited by olemis Loading

olemis Jan 28, 2020

Choose a reason for hiding this comment

olemis Jan 28, 2020

Choose a reason for hiding this comment

olemis Feb 3, 2020

Choose a reason for hiding this comment

olemis Jan 28, 2020

Choose a reason for hiding this comment

olemis Feb 3, 2020

Choose a reason for hiding this comment

olemis left a comment

Choose a reason for hiding this comment

e1Ru1o commented Jan 24, 2020 •

edited by olemis

Loading