Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log app events to file #298

Closed
4 tasks
olemis opened this issue Dec 24, 2019 · 0 comments · Fixed by #317
Closed
4 tasks

Log app events to file #298

olemis opened this issue Dec 24, 2019 · 0 comments · Fixed by #317
Assignees
@AntiD2ta
Labels
config App configuration stdev wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
Milestone
0.27.0

Comments

@olemis
Copy link
Contributor

olemis commented Dec 24, 2019

Is your feature request related to a problem? Please describe.
App events are logged to stdout , which opens a separate console window when running app from OS shell.

Describe the solution you'd like
Basically command line window should not be open

  • Add methods to configure logger ouput desination (see logrus docs)
  • Choose stdout by default
  • Wallet app GUI code should set log output to be sent to file
  • Add log file path in QSettings

Describe alternatives you've considered
Hard-coded log file path may lead to conflicts on different platforms . App settings directory could have been chosen as well .
@olemis olemis added the config App configuration label Dec 24, 2019
@olemis olemis added this to To do in FiberCrypto wallet - Iteration 1 via automation Dec 24, 2019
@olemis olemis added this to the 0.27.0 milestone Dec 24, 2019
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 4, 2020
@AntiD2ta
[ui] refs fibercrypto#298 - Add Radio Buttons to select log output de…
f03d126 
…stination and a Combo box to select log level
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 4, 2020
@AntiD2ta
[config] refs fibercrypto#298 - Add default configuration for log level
0364ad1
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 4, 2020
@AntiD2ta
[ui] refs fibercrypto#298 - Add config option for log level
0b39a01
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 5, 2020
@AntiD2ta
[main] [config] refs fibercrypto#298 - Add log level settings
b956f08
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 5, 2020
@AntiD2ta
[ui] refs fibercrypto#298 - Add TextField for log Level
7fbc7a7 
I would like a ComboBox with fixed options, but I couldn't do it right
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 18, 2020
@AntiD2ta
[vendor] refs fibercrypto#298 - Keep references of packages loggers
f3a006e 
This allows to changes logger properties and propagate this changes across all modules's logger
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 18, 2020
@AntiD2ta
[ui] refs fibercrypto#298 - Change path to log level configuration
40a412d
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 18, 2020
@AntiD2ta
[util] refs fibercrypto#298 - Keep references of packages loggers
9cf37c9 
This allows to changes logger properties and propagate this changes across all modules's logger
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 18, 2020
@AntiD2ta
[ui] refs fibercrypto#298 - Change path to log level configuration
a693890
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 18, 2020
@AntiD2ta
[util] refs fibercrypto#298 - Add function to set log's output to a file
9b97156
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 19, 2020
@AntiD2ta
[util] refs fibercrypto#298 - Add some changes to logging package
85f0c7e 
Changes:
- Add SetOutput function to set the desired logger's output given a option
- Return error in SetOutputToFile function
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 19, 2020
@AntiD2ta
[config] refs fibercrypto#298 - Add configuration option for log's ou…
74e7cdd 
…tput

Path: skycoin/log/output
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 19, 2020
@AntiD2ta
[main] refs fibercrypto#298 - Set log's output correctly given option…
fca2d43 
… in settings
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 19, 2020
@AntiD2ta
[ui] refs fibercrypto#298 - Add ui to set log's output in Settings
9ea9df3 
This need to be upgraded
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[logging] refs fibercrypto#298 - Create Writer for none option
4ded230 
Writer that write nothing
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[logging] refs fibercrypto#298 - Add stderr and none options to SetOu…
8bb88cb 
…tput
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[config] refs fibercrypto#298 - Change default value for log's output…
f4215c5 
… to none
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[models] refs fibercrypto#298 - Apply changed settings related to log…
f313996 
…s when they are saved
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[logging] refs fibercrypto#298 - Refactorize code
a2b05a3 
Remove SetOutput function and add GetOutputWriter function to return the io.Writer that needs to be given to SetOutputTo function
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[skycoin] [models] refs fibercrypto#298 - Change output of SkycoinPro…
512ec7a 
…ject's logger

This occurs when the app's logger change its output
@AntiD2ta AntiD2ta added stdev wip Work in progress labels Jan 21, 2020
This was referenced Jan 21, 2020
Merged
Closed
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 21, 2020
@AntiD2ta
[logging] refs fibercrypto#298 - Change permissions of file for logs …
2cfd783 
…to 0600
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 22, 2020
@AntiD2ta
[logging] refs fibercrypto#298 - Add initial tests for logging package
10e5cb0
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 23, 2020
@AntiD2ta
[view] refs fibercrypto#298 - Remove initial implementation of log le…
1651c5f 
…vel Combo Box
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Jan 24, 2020
@AntiD2ta
[test] refs fibercrypto#298 - Fix linter errors
81d34da 
... reported in https://travis-ci.org/fibercrypto/fibercryptowallet/jobs/640725444#L454
FiberCrypto wallet - Iteration 1 automation moved this from To do to Done Jan 25, 2020
olemis added a commit that referenced this issue Jan 25, 2020
@olemis
Merge pull request #317 from simelo/stdevAntiD2ta_t298_Log_events_to_…
91b2ca4 
…file

Fixes #298 - Configuration of app's logger
@stdevCrow stdevCrow mentioned this issue Feb 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntiD2ta AntiD2ta

Labels
config App configuration stdev wip Work in progress
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Fixes #298 - Configuration of app's logger simelo/fibercryptowallet
2 participants
@olemis @AntiD2ta