[test] refs #279 - GetCoins implementations full covered

fibercrypto · Jan 26, 2020 · fd72907 · fd72907
1 parent 595a1c4
commit fd72907
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 2 deletions.
diff --git a/src/coin/skycoin/models/coin.go b/src/coin/skycoin/models/coin.go
@@ -639,7 +639,6 @@ func (in *SkycoinTransactionInput) GetCoins(ticker string) (uint64, error) {
 	} else if ticker == CalculatedHour {
 		return in.skyIn.CalculatedHours * accuracy, nil
 	}
-	// TODO: The program never reach here because util.AltcoinQuotient(ticker) throws an error when a invalid ticker is supplied
 	logCoin.Errorf("Invalid ticker %v\n", ticker)
 	return uint64(0), errors.ErrInvalidAltcoinTicker
 }
@@ -720,7 +719,6 @@ func (out *SkycoinTransactionOutput) GetCoins(ticker string) (uint64, error) {
 	} else if ticker == CalculatedHour {
 		return out.calculatedHours * accuracy, nil
 	}
-	// TODO: The program never reach here because util.AltcoinQuotient(ticker) throws an error when a invalid ticker is supplied
 	logCoin.Errorf("Invalid ticker %v\n", ticker)
 	return uint64(0), errors.ErrInvalidAltcoinTicker
 }

diff --git a/src/coin/skycoin/models/coin_test.go b/src/coin/skycoin/models/coin_test.go
@@ -8,6 +8,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 
 	"github.com/SkycoinProject/skycoin/src/api"
@@ -18,6 +19,7 @@ import (
 	"github.com/fibercrypto/fibercryptowallet/src/coin/skycoin/skytypes"
 	"github.com/fibercrypto/fibercryptowallet/src/core"
 	"github.com/fibercrypto/fibercryptowallet/src/errors"
+	"github.com/fibercrypto/fibercryptowallet/src/util"
 	"github.com/fibercrypto/fibercryptowallet/src/util/requirethat"
 )
 
@@ -1458,6 +1460,25 @@ func TestGetCoins(t *testing.T) {
 		GetCoins(string) (uint64, error)
 	}
 
+	fakeTicker := "MOCKSCOIN"
+	fakeDesc := "Fake coin"
+	fakeExp := 3
+	fakeMeta := core.AltcoinMetadata{
+		Name:          fakeDesc,
+		Ticker:        fakeTicker,
+		Family:        fakeTicker,
+		HasBip44:      false,
+		Bip44CoinType: 0,
+		Accuracy:      int32(fakeExp),
+	}
+	mockPlugin := new(mocks.AltcoinPlugin)
+	mockPlugin.On("RegisterTo", mock.Anything).Return().Run(func(args mock.Arguments) {
+		manager := args.Get(0).(core.AltcoinManager)
+		manager.RegisterAltcoin(fakeMeta, mockPlugin)
+	})
+	mockPlugin.On("GetName").Return(fakeDesc)
+	util.RegisterAltcoin(mockPlugin)
+
 	invalidTicker := "INVALIDTICKER"
 	tests := []struct {
 		name   string
@@ -1473,6 +1494,12 @@ func TestGetCoins(t *testing.T) {
 			obj:    new(SkycoinCreatedTransactionOutput),
 			err:    true,
 		},
+		{
+			name:   "SkycoinCreatedTransactionOutput",
+			ticker: fakeTicker,
+			obj:    new(SkycoinCreatedTransactionOutput),
+			err:    true,
+		},
 		{
 			name:   "SkycoinCreatedTransactionOutput",
 			ticker: Sky,
@@ -1546,6 +1573,12 @@ func TestGetCoins(t *testing.T) {
 			obj:    new(SkycoinCreatedTransactionInput),
 			err:    true,
 		},
+		{
+			name:   "SkycoinCreatedTransactionInput",
+			ticker: fakeTicker,
+			obj:    new(SkycoinCreatedTransactionInput),
+			err:    true,
+		},
 		{
 			name:   "SkycoinCreatedTransactionInput",
 			ticker: Sky,
@@ -1623,6 +1656,12 @@ func TestGetCoins(t *testing.T) {
 			obj:    new(SkycoinTransactionInput),
 			err:    true,
 		},
+		{
+			name:   "SkycoinTransactionInput",
+			ticker: fakeTicker,
+			obj:    new(SkycoinTransactionInput),
+			err:    true,
+		},
 		{
 			name:   "SkycoinTransactionInput",
 			ticker: Sky,
@@ -1680,6 +1719,12 @@ func TestGetCoins(t *testing.T) {
 			obj:    new(SkycoinTransactionOutput),
 			err:    true,
 		},
+		{
+			name:   "SkycoinTransactionOutput",
+			ticker: fakeTicker,
+			obj:    new(SkycoinTransactionOutput),
+			err:    true,
+		},
 		{
 			name:   "SkycoinTransactionOutput",
 			ticker: Sky,