Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial backend unit tests for Skyfiber models and core #136

Closed
12 tasks done
olemis opened this issue Sep 18, 2019 · 2 comments · Fixed by #250
Closed
12 tasks done

Initial backend unit tests for Skyfiber models and core #136

olemis opened this issue Sep 18, 2019 · 2 comments · Fixed by #250
Assignees
@olemis @stdevMac @AntiD2ta @e1Ru1o @mauricio1802
Labels
ci Continuos Integration core Core interfaces skyfiber SkyFiber altcoin plugin
Projects
FiberCrypto wallet - Iteration 1
Milestone
0.27.0

Comments

@olemis
Copy link
Contributor

olemis commented Sep 18, 2019 •
edited
Loading

Feature description

Initial unit test suite .

Is your feature request related to a problem? Please describe.
Project does not have a test suite , hence some regressions have been detected along the way but after merging a features branches into develop .

Describe the solution you'd like
An initial test suite including known vectors for SkyFiber wallets. Run it on Travis on every commit.

Additional context
This should cover the work done for

Possible implementation
Use testing together with stretchr/testify. Might need updates in ./vendor/
@olemis olemis added ci Continuos Integration core Core interfaces skyfiber SkyFiber altcoin plugin labels Sep 18, 2019
@olemis olemis added this to To do in FiberCrypto wallet - Iteration 1 via automation Sep 18, 2019
@olemis olemis added this to the 0.27.0 milestone Sep 18, 2019
@olemis olemis changed the title Initial backend unit tests Initial backend unit tests for Skyfiber models and core Sep 19, 2019
@olemis olemis moved this from To do to In progress in FiberCrypto wallet - Iteration 1 Sep 20, 2019
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Sep 24, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Add skycoin api interface
8f3e462
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Sep 24, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Add initial mocks and test files
b1513e5
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Sep 28, 2019
@e1Ru1o
[skycoin][test] refs fibercrypto#136 - Move SkyFiberPlugin to skycoin…
b5da874 
…/models and fix some dependencies related to it
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Sep 28, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Correct implamentation of SkycoinApiMoc…
ea8a534 
…k and start to test PEX
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 6, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Adding TestMain to mount the mock API
975f693
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 6, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Delete unnecessary code and Add test of…
773958e 
… Skycoin Models to Makefile
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 6, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Add test related to coin.go
3500fc0
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 7, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Set correct body in every mock method
f7df82e
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 7, 2019
@e1Ru1o
[test] refs fibercrypto#136 - Blockchain.go test
e055128
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 7, 2019
@e1Ru1o
[test] refs fibercrypto#136 - account.go test
5526ef2
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 8, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add some test related to wallet.go.
efe5289 
Tests:
- TransactionFinder::AddressesActivity
- SkycoinRemoteWallet::ListWallets
- SkycoinRemoteWallet::CreateWallet
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 8, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Finish to add test related to wallet.go
43953e7 
Tests:
-SkycoinRemoteWallet::IsEncrypted.
-SkycoinRemoteWallet::GetWallet.
-RemoteWallet::GenAddresses.
-RemoteWallet::GetLoadedAddresses.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 9, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add timeout of 30 segs to go test cmd.
2fcc798
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 9, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Use PoolSection param instead of const …
c356976 
…string.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 9, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Initialize SkycoinPEX with poolSection …
0fb2fd8 
…in network_test.go.
e1Ru1o added a commit to simelo/fibercryptowallet that referenced this issue Oct 18, 2019
@e1Ru1o
[test] refs fibercrypto#136 - fix merge errors
0fa0074
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 22, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for RemoteWallet::SendFromAddr…
5051842 
…ess and upgrade RemoteWallet::Sign.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 28, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Change assert by require in test files.
73296ac
@olemis
Copy link
Contributor Author

olemis commented Oct 28, 2019

I added items for individual issues that need testing . @stdevRulo @stdevAntiD2ta pls mark issues as you complete corresponding test cases .

@olemis
Copy link
Contributor Author

olemis commented Oct 28, 2019

pls mark issues as you complete corresponding test cases .

This is for having a notion of progress

AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 28, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Use NewCreateTransactionResponse in Tes…
0153ed6 
…tRemoteWallet tests.

Tests:
- TestRemoteWalletTransfer
- TestRemoteWalletSendFromAddress
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 28, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add skyapi_mock_test.go with functions …
3275961 
…helping mock Sky API methods.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 28, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add require for Calculated Hours ticker…
ff031ed 
… in TestRegisterSkycoinPlugin.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Oct 28, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for RemoteWallet::Spend.
364f2e6
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 8, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for LocalWallet::Transfer.
7a82d9a
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 8, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for LocalWallet::SendFromAddress.
8acecba
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 8, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for LocalWallet::Spend.
eb4bdc4
@AntiD2ta AntiD2ta mentioned this issue Nov 8, 2019
Merged
olemis added a commit to simelo/fibercryptowallet that referenced this issue Nov 12, 2019
@olemis
[ci] refs fibercrypto#136 - Ignore coverage result files
aec310e
olemis added a commit that referenced this issue Nov 12, 2019
@olemis
Merge pull request #229 from simelo/stdevRulo_t136_Add_skycoin_api_cl…
182d03b 
…ient_interface

Backend unit tests for Skyfiber wallet models refs #136
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 15, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Change require.Nil(t, err) for require.…
530ca91 
…NoError(t, err) in account_test.go.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 15, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Upgrade TestLocalWalletGetBalance.
1710aac 
Upgrades:
- Fix require.Equal calls.
- Test GetBalance with a invalid ticker.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 15, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add tests for RemoteWallet of account.go
d8697ff 
Tests:
- RemoteWallet::GetBalance.
- RemoteWallet::ScanUnspentOutputs.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 15, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add tests for LocalWallet of account.go
b1f31c6 
Tests:
- LocalWallet::ScanUnspentOutputs
- LocalWallet::ListTransactions
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 15, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for SkycoinUninjectedTransacti…
d13c122 
…on::GetInputs
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 16, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for SkycoinCreatedTransactionO…
8b80234 
…utput::IsSpent
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 16, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add test for SkycoinPEX::BroadcastTxn
4e4203d
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 16, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Fix return value of SkycoinApiMock::Upd…
109354c 
…ateWallet.

Fix: Return args's index 0 instead of 1
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 16, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Add tests for wallet.go
8070801 
Tests:
- RemoteWallet::Encrypt,
- RemoteWallet:Decrypt
- RemoteWallet::SetLabel
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 16, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Change require.Nil(t, err) for require.…
9bde691 
…NoError(t, err)

Changes on blockchain_test, coin_test and network_test
@AntiD2ta AntiD2ta mentioned this issue Nov 16, 2019
Merged
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 17, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Fix build errors.
87ff0a1 
Change global_mock for mock in new mockSkyApi functions.
AntiD2ta added a commit to simelo/fibercryptowallet that referenced this issue Nov 17, 2019
@AntiD2ta
[test] refs fibercrypto#136 - Fix param unused in mockSkyApi function…
68eb98f 
…s TransactionsVerbose and

Functions:
- OutputsForAddresses
-TransactionsVerbose
FiberCrypto wallet - Iteration 1 automation moved this from In progress to Done Nov 18, 2019
olemis added a commit that referenced this issue Nov 18, 2019
@olemis
Merge pull request #250 from simelo/stdevAntiD2ta_t136_Backend_unit_t…
1f0de6c 
…ests

Fixes #136 - Backend unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemis olemis

@stdevMac stdevMac

@AntiD2ta AntiD2ta

@e1Ru1o e1Ru1o

@mauricio1802 mauricio1802

Labels
ci Continuos Integration core Core interfaces skyfiber SkyFiber altcoin plugin
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Fixes #136 - Backend unit tests simelo/fibercryptowallet
5 participants
@olemis @stdevMac @AntiD2ta @e1Ru1o @mauricio1802